Skip to content

✨ Add openshift-serviceca certificate provider #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

✨ Add openshift-serviceca certificate provider #1969

merged 1 commit into from
May 15, 2025
+209 −4

Conversation

@perdasilva
Copy link
Contributor

@perdasilva perdasilva commented May 15, 2025 •
edited
Loading

Description

Adds openshift-serviceca certificate provider support for webhooks. Enabled via feature gate: WebhookProviderOpenshiftServiceCA

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@perdasilva perdasilva requested a review from a team as a code owner May 15, 2025 13:55
@netlify
Copy link

netlify bot commented May 15, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 158c060
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/6825f261d61659000887a1df
😎 Deploy Preview https://deploy-preview-1969--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented May 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.04%. Comparing base (c9df915) to head (158c060).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/operator-controller/main.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1969      +/-   ##
==========================================
+ Coverage   68.99%   69.04%   +0.05%     
==========================================
  Files          78       79       +1     
  Lines        6979     7011      +32     
==========================================
+ Hits         4815     4841      +26     
- Misses       1884     1888       +4     
- Partials      280      282       +2
Flag Coverage Δ
e2e 41.42% <0.00%> (-0.31%) ⬇️
unit 59.90% <90.62%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

camilamacedo86
camilamacedo86 approved these changes May 15, 2025
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows fine for me looking at the code, but without an e2e, ensuring that it will work 100% is hard. However, we agreed to look at that as a follow-up.

So,

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8f2f1e9 into operator-framework:main May 15, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@ankitathomas ankitathomas Awaiting requested review from ankitathomas

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@camilamacedo86 camilamacedo86

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@perdasilva @camilamacedo86